Fix infinite lifetime in Zend_Cache_Backend_TwoLevels class#18
Open
mahdy-nasr wants to merge 1 commit intomagento:masterfrom
Open
Fix infinite lifetime in Zend_Cache_Backend_TwoLevels class#18mahdy-nasr wants to merge 1 commit intomagento:masterfrom
mahdy-nasr wants to merge 1 commit intomagento:masterfrom
Conversation
Author
|
are there any changes or comments wanted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the
zf1/library/Zend/Cache/Backend/TwoLevels.phpclass which is setting the lifetime for the fast cache_getFastLifetimefunction.It always set the lifetime to infinite (to
nullwhich is casted to0) regardless the$lifetimeparameter because of the default value of the$maxLifetime = null.###The resposible condition part of the code as follow:
which will always evalute to true because of the default value of the
$maxLifetime = null.the issue faced while developing with memcached in Magento 2.2.5.
this is an bug in Zend framework 1 and it solved in early Zend framework 2
Links of the bug:
but I solved same as how it solved in ZF2 :